feat: translate and rotate domains to clip the main frame#130
Merged
paloma-martinez merged 26 commits intomainfrom Sep 18, 2025
Merged
feat: translate and rotate domains to clip the main frame#130paloma-martinez merged 26 commits intomainfrom
paloma-martinez merged 26 commits intomainfrom
Conversation
RomainBaville
requested changes
Sep 10, 2025
Contributor
RomainBaville
left a comment
There was a problem hiding this comment.
The tests failed for me, may be an issue with the origin.
Contributor
There was a problem hiding this comment.
An internal logger have been inplemented in geos.utils.Logger. You may give the chose to the user to use a personal handler (usefull for paraview) an use the internal logger by defaults.
RomainBaville
approved these changes
Sep 15, 2025
Contributor
RomainBaville
left a comment
There was a problem hiding this comment.
It seems good for me, you just may add typing for all your variable.
3 tasks
paloma-martinez
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
clipToMainFrame.pymodifiers that derive the translation and rotation a hexahedral domain has undergone and revert it so the mesh has one extermal vertices set to (0,0,0) and is aligned with (X,Y,Z)This PR includes:
clipToMainFrame.pythat introduces:ClipToMainFramethat inherits fromvtkLandMarkTransformsetting itsSourcePtsandTargetPtsfrom mesh. It leverages to its best Object Bounding Box Tree struct to get is local frame.ClipToMainFramethat inherits fromvtkTransformFilterand is handlingvtkMultiBlockDataSetby fetching the block whose cell is selected as origin and computing rotation, translation from it to be applied globallytest_clipToMainFrame.pythat includes such :hexahedral mesh randomly rotated and translated and test the above utlis. For now it is only checking that the mesh:
a multiBlock mesh imported from reader to check integration (but nothing else)