refactor: Move PVAttributeMappingto geos-pv and create corresponding VTK filter in geos-mesh#128
Merged
paloma-martinez merged 50 commits intomainfrom Sep 26, 2025
Conversation
… filtre deals with the mesh directly
…w_plugin_AttributeMapping Update to main
paloma-martinez
changed the title
PVAttributeMappingto geos-pv and create corresponding VTK filter in geos-mesh
Co-authored-by: paloma-martinez <104762252+paloma-martinez@users.noreply.github.com>
jafranc
approved these changes
Sep 11, 2025
Collaborator
jafranc
left a comment
jafranc
left a comment
There was a problem hiding this comment.
Made just some suggestions to factorize a bit.
Good job !!
jafranc
approved these changes
Sep 24, 2025
jafranc
approved these changes
Sep 24, 2025
paloma-martinez
approved these changes
Sep 25, 2025
…w_plugin_AttributeMapping Update to the last version of the main.
paloma-martinez
deleted the
RomainBaville/feature/VTK_filter_and_paraview_plugin_AttributeMapping
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of the repository refactoring, this will consists in:
--> Delete the filter and the plugin TransferAttributeVolumeSurface (AttributeMapping does the same)
--> Delete the filter VolumeSurfaceMeshMapper (same function than computeElementMap)
close #125
close #135
close #136