Skip to content

feat: feature/byer3/well manager#3971

Open
tjb-ltk wants to merge 80 commits intodevelopfrom
feature/byer3/well_manager
Open

feat: feature/byer3/well manager#3971
tjb-ltk wants to merge 80 commits intodevelopfrom
feature/byer3/well_manager

Conversation

@tjb-ltk
Copy link
Contributor

@tjb-ltk tjb-ltk commented Feb 10, 2026

feat: Formalize definition of well constraints (this replaces #3862 feat: feature/byer3/well constraints)

allow more than 2 constraints per well
minimize restrictions on rate type
allow production/injection constraints for one well (future capability)
improve code for constraint processing in general and also needed for well estimator

Schema changes / refactoring
WellManager replaces CompositionalMultiphaseWell and SinglePhaseWell, well manager implements physic solver interfaces and iterates over wells to fill coupled Jacobin.

WellControl is now either CompositionalMultiphaseWell or SinglePhaseWell, which implements WellControl interfaces . WellControl should be renamed to "Well"

WellControl provides methods independent of fluid model. CompositionalMulitphasewell /singlephasewell are only kept as owners of Jacobian generation kernels. These could be placed in wellcontrol with simple iscompo check, maybe later.

Subsequent PR's based on this PR

wmwe. - well manager PR with well estimator

wmwe + wellhead pressure constraint

tjb-ltk and others added 30 commits September 29, 2025 16:50
…aint class hierachy , 3) Remove all old constraint handling methods/variables, 4) it compiles ...
…t compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml
…d convert compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml"

This reverts commit fa61ab1.
…well initialization vagaries assoiated with useSurfaceConditions=0
@tjb-ltk tjb-ltk self-assigned this Feb 10, 2026
@tjb-ltk tjb-ltk added type: feature New feature or request flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Feb 10, 2026
@tjb-ltk tjb-ltk changed the title Feature/byer3/well manager feat: feature/byer3/well manager Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 66.77337% with 519 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.70%. Comparing base (2b691d5) to head (e33ed8d).

Files with missing lines Patch % Lines
...nts/physicsSolvers/fluidFlow/wells/WellManager.cpp 46.66% 200 Missing ⚠️
...s/CompositionalMultiphaseWellConstraintKernels.hpp 18.71% 152 Missing ⚠️
...ts/physicsSolvers/fluidFlow/wells/WellControls.cpp 74.48% 50 Missing ⚠️
...lls/kernels/CompositionalMultiphaseWellKernels.cpp 48.93% 24 Missing ⚠️
...lvers/fluidFlow/wells/WellLiquidRateConstraint.cpp 0.00% 21 Missing ⚠️
...Solvers/fluidFlow/wells/WellMassRateConstraint.cpp 0.00% 18 Missing ⚠️
...icsSolvers/fluidFlow/wells/WellConstraintsBase.cpp 67.64% 11 Missing ⚠️
...ts/physicsSolvers/fluidFlow/wells/WellControls.hpp 88.31% 9 Missing ⚠️
...icsSolvers/fluidFlow/wells/WellConstraintsBase.hpp 68.75% 5 Missing ⚠️
...lvers/fluidFlow/wells/WellLiquidRateConstraint.hpp 33.33% 4 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3971      +/-   ##
===========================================
- Coverage    58.87%   58.70%   -0.17%     
===========================================
  Files         1356     1373      +17     
  Lines       113234   114202     +968     
===========================================
+ Hits         66668    67046     +378     
- Misses       46566    47156     +590     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tjb-ltk tjb-ltk added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants