Open
Conversation
…aint class hierachy , 3) Remove all old constraint handling methods/variables, 4) it compiles ...
…lephase still needs testing
…t compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml
… to fixed and inputFiles regenerated
…d convert compositionalMultiphaseFlow/soreideWhitson/1D_100cells/1D_benchmark.xml" This reverts commit fa61ab1.
…well initialization vagaries assoiated with useSurfaceConditions=0
herve-gross
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Formalize definition of well constraints (this replaces #3862 feat: feature/byer3/well constraints)
allow more than 2 constraints per well
minimize restrictions on rate type
allow production/injection constraints for one well (future capability)
improve code for constraint processing in general and also needed for well estimator
Schema changes / refactoring
WellManager replaces CompositionalMultiphaseWell and SinglePhaseWell, well manager implements physic solver interfaces and iterates over wells to fill coupled Jacobin.
WellControl is now either CompositionalMultiphaseWell or SinglePhaseWell, which implements WellControl interfaces . WellControl should be renamed to "Well"
WellControl provides methods independent of fluid model. CompositionalMulitphasewell /singlephasewell are only kept as owners of Jacobian generation kernels. These could be placed in wellcontrol with simple iscompo check, maybe later.
Subsequent PR's based on this PR
wmwe. - well manager PR with well estimator
wmwe + wellhead pressure constraint