Skip to content

Refactor CSharpExporter for improved error handling#404

Closed
larpinguser wants to merge 1 commit into
GDRETools:masterfrom
larpinguser:master
Closed

Refactor CSharpExporter for improved error handling#404
larpinguser wants to merge 1 commit into
GDRETools:masterfrom
larpinguser:master

Conversation

@larpinguser
Copy link
Copy Markdown

issues fixed:
-redundant decompiler null checks
-export_resource crashes instead of reporting
-empty get_handled_importers unexplained
-duplicated "cs" string literal
-misleading early err = OK declaration
-no input validation before expensive decompile

@nikitalita
Copy link
Copy Markdown
Collaborator

Thanks!

Just curious, was this to fix bugs that you ran into, or was this just general clean-up?

@AITYunivers
Copy link
Copy Markdown

Thanks!

Just curious, was this to fix bugs that you ran into, or was this just general clean-up?

It's AI, don't merge this. He did the same to my repo.

@larpinguser
Copy link
Copy Markdown
Author

there was basically no ai usage for this one, (if i knew you would come here to talk about this pr i would have recorded me manually typing the code)
2. this was a general clean up, just picked a file and fixed some stuff with it.

@larpinguser larpinguser marked this pull request as draft May 19, 2026 21:04
@larpinguser
Copy link
Copy Markdown
Author

^^ closed because I didn't see a real purpose in this pr, although I supposed ill make a patch release someday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants