fix: specify UTF-8 encoding when reading .csproj file on Windows#397
Merged
nikitalita merged 1 commit intoApr 16, 2026
Merged
Conversation
On Windows systems with non-UTF-8 locale (e.g. Chinese GBK), Python's open() defaults to the system encoding, causing UnicodeDecodeError when reading UTF-8 encoded .csproj files. Fixes UnicodeDecodeError: 'gbk' codec can't decode byte...
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows systems with non-UTF-8 locale (e.g. Simplified Chinese using GBK),
building with
scons platform=windowsfails with:This happens because
open()without an explicit encoding falls back to thesystem default (GBK on Chinese Windows), but the .csproj file is UTF-8 encoded.
Fix
Explicitly set
encoding="utf-8"in theopen()call for .csproj files.