Skip to content

fix(proxmox): improve forced VM stop handling #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lleyton merged 1 commit into from
Sep 22, 2026
Merged

fix(proxmox): improve forced VM stop handling #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions apps/dashboard/src/lib/server/backends/proxmox/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,13 +926,7 @@ export class ProxmoxBackend implements VmBackend {
const status = await this.client.getQemuVm(node, vmid);
if (status.status === 'stopped') return;

let stopUpid: string;
try {
stopUpid = await this.client.stopVm(node, vmid, { overruleShutdown: true });
} catch (err) {
if (!(err instanceof HTTPError) || err.response.status !== 400) throw err;
stopUpid = await this.client.stopVm(node, vmid);
}
const stopUpid = await this.forceStopVm(node, vmid);
try {
await this.client.waitForTask(node, stopUpid);
} catch (err) {
Expand All @@ -949,6 +943,15 @@ export class ProxmoxBackend implements VmBackend {
throw new Error(`VM ${vmid} on node ${node} did not reach stopped state within 60s`);
}

private async forceStopVm(node: string, vmid: number): Promise<string> {
try {
return await this.client.stopVm(node, vmid, { overruleShutdown: true });
} catch (err) {
if (!(err instanceof HTTPError) || err.response.status !== 400) throw err;
return await this.client.stopVm(node, vmid);
}
}

private async destroyVm(node: string, vmid: number): Promise<string | undefined> {
for (let attempt = 1; ; attempt++) {
try {
Expand Down Expand Up @@ -982,7 +985,7 @@ export class ProxmoxBackend implements VmBackend {
async killVm(id: string, proxmoxId?: number): Promise<void> {
clearProxmoxReadCaches();
const { node, vmid } = await this.resolveForMutation(id, proxmoxId);
const upid = await this.client.stopVm(node, vmid);
const upid = await this.forceStopVm(node, vmid);
await this.client.waitForTask(node, upid);
}

Expand Down
Loading