Skip to content

prevent reuse of proxmox ids #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addidotlol merged 4 commits into from
Sep 21, 2026
Merged

prevent reuse of proxmox ids #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c44aec4
fix(vms): prevent Proxmox ID reuse during deletion
addidotlol Sep 20, 2026
eb3a811
fix(vm): prevent deletion races and enforce Proxmox identity
addidotlol Sep 20, 2026
0b29eb9
fix(vm): finalize billing before deletion
addidotlol Sep 20, 2026
800d111
fix(proxmox): require allocated VM IDs during creation
addidotlol Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/dashboard/drizzle/0031_proxmox_vmid_seq.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
CREATE SEQUENCE "public"."proxmox_vmid_seq" INCREMENT BY 1 MINVALUE 1000 MAXVALUE 999999999 START WITH 1000 CACHE 1;--> statement-breakpoint
SELECT setval('proxmox_vmid_seq', GREATEST(COALESCE((SELECT MAX("proxmox_id") FROM "vms"), 0) + 1, 1000), false);
7 changes: 7 additions & 0 deletions apps/dashboard/drizzle/0032_unique_active_proxmox_id.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
UPDATE "vms" SET "proxmox_id" = NULL WHERE "id" IN (
SELECT "id" FROM (
SELECT "id", row_number() OVER (PARTITION BY "proxmox_id" ORDER BY "created_at" DESC) AS "rank"
FROM "vms" WHERE "active" AND "proxmox_id" IS NOT NULL
) "ranked" WHERE "rank" > 1
);--> statement-breakpoint
CREATE UNIQUE INDEX "vms_active_proxmox_id_unique" ON "vms" USING btree ("proxmox_id") WHERE "vms"."active";
Loading
Loading