ci: add GitHub Actions workflow for tests and typecheck + migrate to Node.js 24 - #2
Merged
Conversation
Pin the runtime to Node 24 via .nvmrc, bump engines to >=24, and update @types/node to 24.12.2 to match. Remove the --experimental-strip-types flag from npm test and from documentation: native TypeScript execution is enabled by default since Node 23.6. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Run npm run typecheck and npm test on push and pull_request to main, reading the Node version from .nvmrc to keep CI aligned with local dev. Restrict GITHUB_TOKEN to contents:read (least privilege) and cancel obsolete PR runs via a concurrency group, while preserving full history on main. Add a CI status badge to README.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sebastienthibaud
changed the title
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions CI workflow and aligns the project’s Node/TypeScript execution and documentation around Node.js 24 (including updated test invocation and contributor requirements).
Changes:
- Add a GitHub Actions CI workflow running
typecheckandteston PRs andmain. - Update test command/docs to run TypeScript directly via
node(and bump Node engine +@types/nodeto v24). - Add
.nvmrcand update documentation/README to reflect CI + new Node baseline.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/run.ts |
Updates the documented test invocation to node tests/run.ts. |
package.json |
Updates test script, bumps Node engine requirement to >=24, and updates @types/node. |
package-lock.json |
Lockfile updates reflecting the @types/node bump (and transitive updates). |
doc/contribution.md |
Updates contributor requirements to Node 24 and new @types/node version. |
commands/speckit.analytics.purge.md |
Updates purge command examples to remove experimental TS flags. |
README.md |
Adds CI badge pointing to the new workflow. |
.nvmrc |
Pins local development Node major version to 24. |
.github/workflows/ci.yml |
Adds CI workflow for install, typecheck, and tests using .nvmrc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Node's ESM resolver treats specifiers that don't start with ./ , ../ ,
/ , or a URL scheme as bare specifiers (package names). The purge
command examples used import('.specify/...') which fails with
ERR_INVALID_MODULE_SPECIFIER.
Prefix the paths with ./ so the dynamic import resolves as relative
from the project root.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
RamziSayagh
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GitHub Actions CI workflow and aligns the project’s Node/TypeScript execution and documentation around Node.js 24 (including updated test invocation and contributor requirements).
Changes: