fix: treat empty-horizon cancel as processed - #8
Open
donalffons wants to merge 1 commit into
Open
donalffons wants to merge 1 commit into
donalffons wants to merge 1 commit into
Conversation
A canceled order can still have leftover mapped actions. Treat an empty node/edge horizon as processed and keep scanning cancelOrder while retries are in flight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A canceled order with leftover mapped actions never reached
onOrderProcessed. After merge, an empty node/edge horizon counts as processed so Blink can confirm cancel and retry.Design & Architecture Decisions
cancelOrderinstant action instead of returning on the first mismatch, so a retry's new cancel is still observed.Business Logic, Decision Tree, Data Flow
flowchart LR State[AGV state] --> Canceled{cache.canceled and empty horizon?} Canceled -->|yes| Processed([onOrderProcessed byCancelation]) Canceled -->|no| Library[_isOrderProcessed] Library --> Done{Processed?} Done -->|yes| Processed Done -->|still active| Wait([Wait next state])Structure & Composition
src/controller/master-controller.tssrc/test/master-controller-cancellation-pending.test.tsAssumptions & Decisions
Test Coverage
cancelOrderis still seen.byCancelationacross frames.PR Stack
N/A — standalone library PR. Blink #376 consumes this commit as a submodule pointer.
Reviewer TODO
cancelOrderis required when retries publish a second cancel.