Repository navigation
contract: the unit create, configurator cap and millwork 404 match the code - #107
Merged
Merged
Conversation
…e code UnitCreate requires dimension (unit/input.go refuses a create without one); the configurator bodies are bounded by the platform's 10 MiB limit with a 413, not 64 KiB; the millwork option read answers not_found beside app_disabled. The worker package comment names its six jobs and the exposure scheduler comment names the outbox, not the in-process bus. openapi.yaml and the TypeScript types are regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: colton <colton@futurebuild.ai>
…act-prose-drift Signed-off-by: colton <colton@futurebuild.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract and comment text that disagreed with the code. No wire change: every response the server gives is unchanged; the contract now describes it.
units.yamlUnitCreaterequired: [code, name], "the dimension defaults to count"unit/input.gorefuses a create withoutdimension("is required"), so it joinsrequiredconfigurator.yamlvalidate and build-skuhttpx.DecodeJSONmaps the platform'sMaxRequestSize(10 << 20)(app/serve/chain.go) to a 413, already listedmillwork.yamlmillworkGetOption404AppDisabledonlymillwork/service.goanswershttpx.NotFoundfor an unknown id; the 404 is nowoneOfAppsDisabledErrorandWireError(disjoint:app_disabledonly, andmetarequired)worker.gopackage commentRunlogs: idempotency purge, outbox drain, outbox purge, draft events purge, order allocation, order fulfilmentexposure_scheduler.gocommentopenapi.yaml(go run ./api/tools/merge) andweb/packages/api-client/src/schema.d.ts(npm run generate) are regenerated. Gates run locally: merge-checkfresh (406 operations), pending fresh (0 pending),go test ./internal/apicontract/...ok, conformance 1289 golden steps validated,npm run driftandnpm run typecheckok,go build ./...,go vetand gofmt on both packages clean,bash scripts/check-shape.shOK. No frontend code builds a unit create body.🤖 Generated with Claude Code