Repository navigation
fix: persist FusionCaptcha state when cache is disabled - #166
Merged
Nightprince merged 2 commits intoSep 26, 2026
Merged
Conversation
Store FusionCaptcha challenge/token state in its own file-backed cache so captcha verification still works when FusionCMS global data cache is disabled. Also avoid reusing a user-agent-bound challenge for another browser sharing the same IP, preventing ua_mismatch during redemption.
Dutchevil
force-pushed
the
fix/fusion-captcha-cache-disabled
branch
from
September 24, 2026 11:32
39a9bf7 to
a067ebb
Compare
Add the missing admin language string used by the captcha type selector so the settings page renders when FusionCaptcha is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writable/cache/data/captcha, independent of FusionCMS' global data cache toggle.ua_mismatchon redemption.Why
When
$config['cache'] = false, FusionCaptcha still returns a challenge from/captcha/challenge, but the challenge is not saved through the global Cache library./captcha/redeemthen cannot find the challenge and returns{"success":false,"error":"expired"}, causing the login/register widget to fail after solving.A live FusionCMS install reproduced this as a captcha widget that loaded to the final step and then displayed
Error! Please try again.Test plan
git diff --checkphp -l application/libraries/FusionCaptcha.phpusing PHP CLI in Docker/captcha/redeemchanged fromexpiredtosuccess:trueand the browser widget reachesVerified!.