Don't use complex variants of standard blend modes #16
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiply, you will be missed |
ok but real shit why was this using khr its a simple blend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in the Funkin' Contributors discord, where pixel note splashes overdraw each other:
This happened because the note splashes use the SCREEN blend mode, which has both a standard and complex implementation. Because of this, they weren't marked as a KHR blend mode in
FunkinCamera, which ended up not breaking up the sprite batch, which caused the same issue as FunkinCrew/Funkin#6786.The easiest solution would be to just use the standard implementation of the blend mode, which is what's done here.