Repository navigation
馃煛 [API] AgentService response type inconsistency聽#16
Description
Problem
chat() returns AsyncIterator[str] | str:
response: AsyncIterator[str] | strThis forces consumers to branch on type, creating complexity.
Solution
Always return consistent type:
@dataclass
class AgentResult:
stream: AsyncIterator[str]
searched: bool
search_query: str | None
matches: List[SearchHit]
async def collect(self) -> str:
'''Consume stream and return full text.'''
return ''.join([chunk async for chunk in self.stream])Acceptance Criteria
- AgentResponse always has stream
- Helper to collect full response
- CLI uses consistent consumption
Activity
FullFran commentedon Jan 26, 2026
Sigue abierta. en sigue siendo , y no hay un tipo unificado tipo AgentResult con stream + collect. Dejo abierta.
FullFran commentedon Jan 26, 2026
Corrijo comentario anterior (el backtick se interpret贸 en shell).
Sigue abierta.
AgentResponse.responseensrc/services/agent_service.pysigue siendoAsyncIterator[str] | str, y no hay un tipo unificado tipo AgentResult con stream + collect.FullFran commentedon Jan 26, 2026
Resuelto.
AgentServiceahora devuelveAgentResultconstreamsiempre presente y m茅todocollect(). Se normaliza el stream ensrc/services/agent_service.pyy el CLI/tests consumenresult.streamocollect().refactor: unify AgentService response to AgentResult with stream