fix(explorer): starlette template response convention #139 - #140
Merged
Merged
Conversation
The legacy (name, context-with-request) shim was removed in starlette 1.6, breaking every page load of the --explore server with .The keyword-arg form works on both sides of the 1.6 boundary. Fixes #139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139 — the
--exploreserver failed on every page load withTypeError: unhashable type: 'dict'under starlette ≥ 1.6.TemplateResponseto the request-first keyword form(supported since starlette 0.29, so compatible with both old and new versions)
GET /— the only template-rendering route, previously untested(in-process TestClient + e2e against the real server)
DeprecationWarningto test failures so the next upstream APIremoval is caught while still a warning
Thanks @zilto for raising this