Fix multicast socket option mapping - #388
Open
UnitZeroOne wants to merge 1 commit into
Open
UnitZeroOne wants to merge 1 commit into
UnitZeroOne wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The POSIX socket bridge treats several IPv4 multicast options as four-byte integers. TTL and loopback are one-byte values, while interface and membership options contain network-order addresses.
This can overwrite the TTL/loopback buffers, reverse address bytes on little-endian hosts, and leave part of a membership request uninitialized.
Fix
Handle TTL and loopback as single bytes, copy the address structures without changing byte order, and reject invalid lengths with
EINVAL.This is intentionally a small, focused fix. Related
getsockopt()handling, allocation checks, and broader guest-memory validation are left for separate changes.