Skip to content

Draft: Add builder methods#4

Draft
BitSyndicate1 wants to merge 5 commits intoFriz64:rewritefrom
BitSyndicate1:rewrite-builders
Draft

Draft: Add builder methods#4
BitSyndicate1 wants to merge 5 commits intoFriz64:rewritefrom
BitSyndicate1:rewrite-builders

Conversation

@BitSyndicate1
Copy link
Copy Markdown

No description provided.

@BitSyndicate1 BitSyndicate1 marked this pull request as draft May 3, 2026 21:35
Copy link
Copy Markdown
Owner

@Friz64 Friz64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty good already, nice work

Comment thread analysis/src/item/structure.rs Outdated
Comment thread generator-rewrite/src/item/structure.rs Outdated
@Friz64
Copy link
Copy Markdown
Owner

Friz64 commented May 4, 2026

oh and we also need to reexport this new trait in the vk module

vfs.write("vk.rs", quote! { pub use crate::Handle; });

@BitSyndicate1
Copy link
Copy Markdown
Author

oh and we also need to reexport this new trait in the vk module

vfs.write("vk.rs", quote! { pub use crate::Handle; });

done

@Friz64
Copy link
Copy Markdown
Owner

Friz64 commented May 4, 2026

looking good

@BitSyndicate1 BitSyndicate1 changed the title Draft: add TaggedStructure trait to rewrite Draft: Add builder methods May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants