Repository navigation
Let the Rust descriptor test wait for exiting threads - #25
Merged
Merged
Conversation
A joined thread can stay listed in /proc/self/task briefly after it exits, so an exact count taken at once intermittently saw one extra thread (main CI failed this way after the Rust SDK merge). Poll for up to two seconds for the counts to return to the baseline; a real leak still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust/tests/descriptors.rscounted/proc/self/fdand/proc/self/taskimmediately after each invocation. A joined thread can stay listed in/proc/self/taskfor a moment after it exits, so the exact count intermittently saw one extra thread ("threads grew from 2 to 3"). This failed CI on main after the Rust SDK merge, and twice on another branch.The test now polls for up to two seconds until each count returns to its baseline. A leak persists, so it still fails: with a deliberately leaked thread added, the test fails with "threads grew from 2 to 3". Without it, the test passed 20 of 20 local runs, and clippy and rustfmt are clean. Test-only change.