Repository navigation
Make clean-checkout tests build first and cover rollback under root - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running npm test immediately after npm ci previously failed because process and hook tests require compiled dist files. Add pretest build and document that workflow. Replace the chmod-dependent rollback setup with a targeted EACCES write failure, verifying that the plugin is written first and then removed with no adapter/config record left behind; root now exercises the same rollback assertion.
Validation: a worktree starting without dist passed all 470 tests via npm test, plus typecheck, boundary check and all 11 generated plugin files. The rollback case also passed as UID 0 in an isolated Node 22.23.4 container. An independent source review found no blockers. Runtime behavior and the published runtime artifact are unchanged.