Repository navigation
Fail capacity profiles with unsynced captures and retain cleanup recovery - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync capacity profiler could exit successfully when background transport failures left captures queued. It now waits for bounded convergence and requires completed discovery, zero pending captures, and an error-free synced state. Failed cleanup retains the disposable identity, session, and local state in a private recovery file instead of discarding the credentials needed to repair it.
Validation: a real child-process regression drops every local HTTP connection, confirms a failing verdict with pending captures, checks the recovery file is mode 0600, and verifies the secret never appears in stdout (1/1 passed). Script syntax and whitespace checks passed. This changes an operator script and its regression test; the released runtime is unchanged.