Repository navigation
Record why bounded recall fell back to free hot memory - #13
Merged
Merged
Conversation
The fallback action now carries a classified failure (timeout, aborted, HTTP status and error code, or an error name) so local logs distinguish a client timeout from a server error or a recall deadline. Messages, URLs and bodies are never copied.
Contributor
Author
Independent review: approve with nitsThe classifier is correct: Nits (fixes coming):
|
… charged The recorded failure code passes the same identifier check as the error name. The fallback warning now follows the failure class: a server deadline that reports nothing charged says so, a 4xx names the rejection, and only timeouts, network failures and unconfirmed server errors keep the may-still-settle caution. A lifecycle test asserts that the fallback action records details.failure.
Contributor
Author
|
Review nits are fixed in 782f02b.
Verification: typecheck 0, build 0, focused tests 15/15, full suite 402/402. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounded hosted recall now records sanitized failure reasons and distinguishes confirmed zero-charge failures from unknown commit outcomes. Unknown commits require a retry with the same idempotency key. Local-first sessions continue to skip automatic paid recall.
Validation at 3c6a523: typecheck, boundary check, build, and 431/431 local tests passed. Node 22/24 CI, reproducible build, native-host Docker and coding-host journeys passed. Regression cases cover deadlines, timeouts, unknown commits, contradictory charge claims and verified-hot-memory fallback. Server counterpart: onlybots MR !31.