fix: run the clone command in the web container ('service nodejs does not exist')#12
Open
gkastanis wants to merge 1 commit into
Open
fix: run the clone command in the web container ('service nodejs does not exist')#12gkastanis wants to merge 1 commit into
gkastanis wants to merge 1 commit into
Conversation
…dejs service commands/nodejs/clone requires a 'nodejs' service that nothing in the current stack defines: this add-on ships no docker-compose service, DDEV-Canvas names its node service 'storybook', and this README states the pipeline runs in the web container. 'ddev clone' therefore fails on every current install with 'service nodejs does not exist'. Move the command to commands/web/ (the web container has node and the pipeline deps via the post-start daemon) and update the two comments that referenced the nodejs container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
commands/nodejs/clonetargets anodejsservice that nothing in the current stack defines:nodejsdocker-compose service andinstall.yamldocuments no prerequisite for one,storybook,So
ddev clone <url>— the exact command the post-install message tells users to run — fails on every current install:Fix
Move the command to
commands/web/clone. Verified working there: the web container has node 24 and the pipeline's dependencies via the post-start daemon. Also updatesinstall.yaml'sproject_filesentry and the two comments (in the command and the README) that referenced the nodejs container.Testing
Ran the moved command's exact body in the web container today (2026-07-15) against a real site with
--scope homepage: full mechanical pipeline (screenshots, DOM sections, assets) completed in ~4 minutes, exit 0.Found while standing up an eval environment for the Canvas migration tooling. Related PR in the same sweep: the flagship skill filename fix (see the sibling PR).
🤖 Generated with Claude Code