Skip to content

[1.0.0] Use Options DTO.#8

Merged
ChadSikorra merged 3 commits into
mainfrom
upgrade/options-dto
May 4, 2026
Merged

[1.0.0] Use Options DTO.#8
ChadSikorra merged 3 commits into
mainfrom
upgrade/options-dto

Conversation

@ChadSikorra

Copy link
Copy Markdown
Contributor

Replaces options array with an options DTO. Bumps PHPStan to max.

@ChadSikorra ChadSikorra force-pushed the upgrade/options-dto branch from e894478 to 147e155 Compare May 4, 2026 16:43
@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.25243% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.24%. Comparing base (8ce4b2d) to head (6b73924).

Files with missing lines Patch % Lines
...c/FreeDSx/Sasl/Security/DigestMD5SecurityLayer.php 0.00% 26 Missing ⚠️
src/FreeDSx/Sasl/Options/DigestMD5Options.php 80.00% 12 Missing ⚠️
src/FreeDSx/Sasl/Message.php 71.79% 11 Missing ⚠️
src/FreeDSx/Sasl/Challenge/DigestMD5Challenge.php 82.85% 6 Missing ⚠️
...rc/FreeDSx/Sasl/Challenge/ResolvesOptionsTrait.php 37.50% 5 Missing ⚠️
src/FreeDSx/Sasl/Options/SaslOptions.php 50.00% 3 Missing ⚠️
src/FreeDSx/Sasl/Options/ScramOptions.php 92.50% 3 Missing ⚠️
src/FreeDSx/Sasl/Challenge/CramMD5Challenge.php 93.75% 1 Missing ⚠️
...c/FreeDSx/Sasl/Factory/DigestMD5MessageFactory.php 94.11% 1 Missing ⚠️
src/FreeDSx/Sasl/Mechanism/DigestMD5Mechanism.php 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #8      +/-   ##
============================================
+ Coverage     76.72%   78.24%   +1.52%     
- Complexity      432      521      +89     
============================================
  Files            27       35       +8     
  Lines          1293     1531     +238     
============================================
+ Hits            992     1198     +206     
- Misses          301      333      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChadSikorra ChadSikorra merged commit 888f3d1 into main May 4, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant