Skip to content

[1.0.0] Properly react to alias dereferencing requests. It's not supported (for now).#175

Merged
ChadSikorra merged 1 commit into
FreeDSx:mainfrom
ChadSikorra:upgrade/alias-deref
Jun 7, 2026
Merged

[1.0.0] Properly react to alias dereferencing requests. It's not supported (for now).#175
ChadSikorra merged 1 commit into
FreeDSx:mainfrom
ChadSikorra:upgrade/alias-deref

Conversation

@ChadSikorra

Copy link
Copy Markdown
Contributor

Alias dereferencing is not supported on the backend. This at least detects if it was requested and produces a proper result code rather than straight up ignoring it. I'm not sure I actually want to add alias dereferencing to the backend, as it seems like it adds a lot of complexity and the use case for it seems narrow.

@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.54930% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.58%. Comparing base (e77ce88) to head (a89f8af).

Files with missing lines Patch % Lines
.../Server/Backend/Storage/WritableStorageBackend.php 86.84% 5 Missing ⚠️
...eDSx/Ldap/Server/Backend/Storage/AliasDetector.php 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #175   +/-   ##
=========================================
  Coverage     88.57%   88.58%           
- Complexity     4998     5018   +20     
=========================================
  Files           425      426    +1     
  Lines         17548    17613   +65     
=========================================
+ Hits          15543    15602   +59     
- Misses         2005     2011    +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChadSikorra ChadSikorra merged commit 9d54cd5 into FreeDSx:main Jun 7, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant