[1.0.0] Properly react to alias dereferencing requests. It's not supported (for now).#175
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 88.57% 88.58%
- Complexity 4998 5018 +20
=========================================
Files 425 426 +1
Lines 17548 17613 +65
=========================================
+ Hits 15543 15602 +59
- Misses 2005 2011 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alias dereferencing is not supported on the backend. This at least detects if it was requested and produces a proper result code rather than straight up ignoring it. I'm not sure I actually want to add alias dereferencing to the backend, as it seems like it adds a lot of complexity and the use case for it seems narrow.