[1.0.0] Add a maxSearchLookthrough option as a toggle on the server (Part 1)#173
Merged
Merged
Conversation
…n-limited filter scans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a toggle to prevent large scans when the backend storage cannot properly limit certain searches. The server would otherwise return a huge set of entries that PHP would then have to scan through and filter itself. This allows placing a cap on that. By default it is set to 5k. This seems like a reasonable value for this sort of backend. OpenLDAP is actually unlimited while 389DS sets the default to 5k.
This is part 1. A second part will allow this limit to be applied via a matching rule (so it can be applied individually) and also add a separate limit for paged searches (as this also applies across all pages of a paged search).