[1.0.0] Normalize DNs in an RFC 4518 caseIgnore style way.#172
Merged
Conversation
ChadSikorra
force-pushed
the
upgrade/dn-normalization
branch
from
81c14e4 to
ab7aef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies DN normalization consistently, handling whitespace better. For the normal ascii cases it uses a more optimized version to avoid performance penalties for doing this all over the place. The normalization is also memoized, so it's not done constantly. However, this still avoids value unescaping for the moment. But this needs to be done as it impacts binds / evaluations / ACL / etc.