Skip to content

[1.0.0] Optimizations / PHPStan fixes.#13

Merged
ChadSikorra merged 5 commits into
mainfrom
upgrade/phpstan-again
Apr 27, 2026
Merged

[1.0.0] Optimizations / PHPStan fixes.#13
ChadSikorra merged 5 commits into
mainfrom
upgrade/phpstan-again

Conversation

@ChadSikorra

Copy link
Copy Markdown
Contributor

More optimizations and phpstan fixes.

@codecov

codecov Bot commented Apr 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.58879% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.10%. Comparing base (8754e69) to head (54cae34).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/FreeDSx/Asn1/Encoder/BerEncoder.php 91.17% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #13      +/-   ##
============================================
+ Coverage     95.04%   95.10%   +0.06%     
- Complexity      367      379      +12     
============================================
  Files            24       24              
  Lines           929      961      +32     
============================================
+ Hits            883      914      +31     
- Misses           46       47       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChadSikorra ChadSikorra force-pushed the upgrade/phpstan-again branch from 9217fd7 to 52e39a1 Compare April 26, 2026 22:08
…dditionally, cache some values to avoid constantly calling some methods multiple times.
@ChadSikorra ChadSikorra force-pushed the upgrade/phpstan-again branch from ead7c2b to b3ba824 Compare April 26, 2026 22:54
@ChadSikorra ChadSikorra force-pushed the upgrade/phpstan-again branch from 487b360 to ec58d88 Compare April 26, 2026 23:20
@ChadSikorra ChadSikorra force-pushed the upgrade/phpstan-again branch from 08c666c to 54cae34 Compare April 26, 2026 23:35
@ChadSikorra ChadSikorra merged commit 4690075 into main Apr 27, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant