Skip to content

Check if GTest is available before downloading#9

Merged
chennes merged 1 commit into
FreeCAD:mainfrom
bkmgit:bkmgit-patch-1
Jun 9, 2026
Merged

Check if GTest is available before downloading#9
chennes merged 1 commit into
FreeCAD:mainfrom
bkmgit:bkmgit-patch-1

Conversation

@bkmgit

@bkmgit bkmgit commented Sep 1, 2025

Copy link
Copy Markdown

Enable use of GTest that is already available.

@bkmgit

bkmgit commented Sep 1, 2025

Copy link
Copy Markdown
Author

This is similar to #1 though gmock needs to be linked in a similar manner to gtest_main on newer CMake versions.

@aiksiongkoh

Copy link
Copy Markdown

Does your PR supersede
#1

@chennes

chennes commented Oct 9, 2025

Copy link
Copy Markdown
Member

I think we should be using the QUIET option to the find_package command there, right?

@bkmgit

bkmgit commented Nov 12, 2025

Copy link
Copy Markdown
Author

Added QUIET option as done in #1, can rebase changes on top of #1 if that would be better.

@chennes

chennes commented May 12, 2026

Copy link
Copy Markdown
Member

@bkmgit if this is still something you're interested in pursuing, can you rebase? FreeCAD itself is going to drop all the FetchContent calls and simply make gtest a system requirement if you want to build the tests, so we could also make that change here, instead.

@bkmgit

bkmgit commented May 12, 2026

Copy link
Copy Markdown
Author

@chennes Done.

@chennes

chennes commented May 13, 2026

Copy link
Copy Markdown
Member

@aiksiongkoh do you want to test this to make sure it works on your development environment before we merge it?

@PaddleStroke

Copy link
Copy Markdown

@chennes I don't think that he'll feedback on that. I think Aik-Siong has a dev version of the solver that diverged significantly and he's not so proficient in handling development environment. So I'd venture a guess that he does not know how to test this. So if this change is needed you should probably go ahead and merge it.

@chennes chennes merged commit 104893c into FreeCAD:main Jun 9, 2026
@bkmgit bkmgit deleted the bkmgit-patch-1 branch June 9, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants