Limits-are-for-dragging-only#11
Open
aiksiongkoh wants to merge 2 commits into
Open
Conversation
Member
|
@aiksiongkoh is this ready for merge now? We should do one more sync with FreeCAD before the 1.1 release, should this be in it? |
Author
|
Let me check with Pierre. |
Member
|
This obviously completely fell off my radar. What's the status here? |
|
I think we can probably merge this. However there are many .asmt and .log file (most of the diff). Are they necessary? |
Member
|
@PaddleStroke those are getting used in the tests (though the tests themselves aren't very clear: I assume those commands have side effects/throw exceptions if they fail? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runKINEMATIC does not use limits.