Repository navigation
fix: restore the executable bit on the git hook scripts - #159
Merged
Merged
Conversation
`scripts/git-hooks/pre-commit` and `scripts/hooks/update-metadata.sh` were committed as 100644. Git refuses to run a hook that is not executable, so `scripts/install-hooks.sh` installs a pre-commit hook that silently never fires on Linux and macOS. Windows is unaffected, which is why this went unnoticed. Mode change only, no content change. `install-hooks.bat` stays 100644 -- it is invoked through cmd, not exec'd. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/git-hooks/pre-commitandscripts/hooks/update-metadata.share both committed as mode100644.Git will not run a hook that is not executable — it skips it without a word. So on Linux and macOS,
scripts/install-hooks.shinstalls a pre-commit hook that silently never fires: no clang-format check, no@date/@copyrightstamping. Windows does not honour the POSIX permission bit, which is why nobody noticed.The bit was present on
chore/metadata-hook(100755) and got lost when #153 was squashed intodev.Change
Mode change only, zero content change:
scripts/install-hooks.batdeliberately stays100644— it is invoked throughcmd, neverexec'd. Every other script in the repo (formatter.sh,scripts/install-hooks.sh,Mk2_3phase_RFdatalog_temp/scripts/tune_cloud_immunity.sh) is already100755.Verification
No firmware source is touched, so builds and tests are unaffected.
🤖 Generated with Claude Code