Repository navigation
Conversation
The configurator of the 3-phase firmware lives with its firmware (3-phase/configurator, tested there against the shipped config files). It is published here, from the submodule, at /configurateur/: the online version always matches the documented firmware. - conf.py copies the page (html, css, js) into the HTML output after the build, and warns if the submodule has no configurator yet; - new page firmware/configurateur-triphase, linked from the 3-phase firmware configuration, the mk2Wifi installation and the Home Assistant note; - the Sphinx workflow no longer ignores the 3-phase submodule, so a bump republishes it. Co-Authored-By: Claude <noreply@anthropic.com>
PCB_VERSION instead of OLD_PCB (which only exists in the 1-phase firmware), the load map, the startup priorities, temperature sensing and the file tree, as in the current config.h. Co-Authored-By: Claude <noreply@anthropic.com>
Neither firmware scans for probes or has TEMP_ENABLED any more: read the addresses with the OneWire library's DS18x20_Temperature example. Co-Authored-By: Claude <noreply@anthropic.com>
The load map, the startup priorities, temperature sensing and the file tree, as in the current 1-phase config.h. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Publishes the firmware configurator of the 3-phase router at https://fredm67.github.io/Mk2PVRouter/configurateur/ and documents it.
The configurator's code and tests stay in the firmware repository (FredM67/PVRouter-3-phase#183,
configurator/). There, a CI check fails a firmware PR that changesconfig.huntil the configurator follows. This site only publishes it, from the3-phasesubmodule, so the online version always matches the documented firmware.Changes
content/conf.py: abuild-finishedhook copies3-phase/configurator/*.{html,css,js}intoconfigurateur/of the HTML output. If the submodule has no configurator yet, it logs a warning and skips the copy, so the build never breaks.firmware/configurateur-triphase.rst(in the « Logiciel & Étalonnage » menu): what the configurator does, how to use it, the mk2Wifi YAML and its fail-safe controls.firmware-triphase.inc.rst);principe-fonctionnement.rst, which also keeps the gist link.documentation.yaml: the3-phasesubmodule (and.gitmodules) are no longer inpaths-ignore, so bumping the submodule republishes the configurator.Merge order
dev, thendevintomain.3-phasesubmodule here to thatmain, in this PR or right after it.Merged before the bump, nothing breaks: the build warns that it found no configurator, but the new page links to a URL that doesn't exist yet.
Tested locally
sphinx-build -b dirhtmlwith the submodule on the configurator branch:configurateur/holds the page, and the new page renders.hardwaresubmodule not checked out, and drawio not installed.🤖 Generated with Claude Code
Also fixed
firmware-triphase.inc.rstdescribed settings the 3-phase firmware does not have:OLD_PCB(1-phase only) is replaced byPCB_VERSION(FredM67/PVRouter-3-phase#184). The load map, startup priorities, temperature sensing (TEMP_SENSOR_PRESENT,temperatureSensing, no address scan in the firmware) and the file tree now match the currentconfig.h.firmware-monophase.inc.rsthad the same stale examples (file tree,physicalPin_dump_load,dumpLoad_startup_sequence,TEMP_ENABLED,sensor_list): now as in the 1-phaseconfig.h(itsOLD_PCBpart was right).common/moniteur-serie.inc.rstno longer says the router lists the probe addresses: it points to the OneWireDS18x20_Temperatureexample. Temperature sensing only builds on the 1-phase firmware once FredM67/PVRouter-1-phase#21 is merged.