Fix Quasar light module having 0 radius with rgb_points#156
Open
Neddslayer wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
As per the bug report, if the color gradient or the brightness is not constant but the radius is, it will never be initialized in the constructor and be always zero. The same thing applies to the brightness if either of the other two are not constant. This PR fixes these issues by properly applying the brightness and radius in the constructor if either are constant. I also removed setting the
lastBrightnessvalue at the end ofupdate(), as that seemed to cause some flickering. Feel free to let me know if there are any issues!