Allow ErrorCode enum names in yamsql error directives#4200
Open
arnaud-lacurie wants to merge 2 commits into
Open
Allow ErrorCode enum names in yamsql error directives#4200arnaud-lacurie wants to merge 2 commits into
arnaud-lacurie wants to merge 2 commits into
Conversation
Yamsql test files can now use human-readable ErrorCode enum names (e.g. SYNTAX_ERROR) in addition to raw SQLSTATE codes (e.g. 42601). The parser resolves enum names to their 5-char code at parse time; failure messages show both name and code on each side. All existing yamsql error directives updated to use enum names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yamsql
error:directives now acceptErrorCodeenum names (e.g.SYNTAX_ERROR) in addition to raw SQLSTATE codes. Failure messages showNAME (code)on both sides. All yamsql files updated;showcasing-tests.yamsqldemonstrates both forms.