Branch coverage experiment#4191
Draft
ScottDugas wants to merge 5 commits into
Draft
Conversation
…dicates
Extend `Expression.Utils.toUnderlyingPredicate()` to handle value types other than `BooleanValue`, in particular `ConstantObjectValue` and `NullValue`. Among other boolean expression types, this fixes a gap that prevented a `TRUE`, `FALSE`, or `NULL` literal from being used directly as a `WHERE` or `JOIN … ON` predicate.
Testing:
* `join-tests.yamsql` covers `WHERE {TRUE|FALSE|NULL}` and `JOIN … ON {TRUE|FALSE|NULL}`.
* `boolean-ddl.yamsql` exercises the “for DDL” code path via `CREATE INDEX … WHERE {TRUE|FALSE|NULL}`.
Resolves FoundationDB#4150.
The data was already gathered via JaCoCo so this just exposes it in the same way as the line coverage. branch coverage is omitted if the changed lines have no branches.
With the branch coverage it's a bit length and hard to read, use two lines.
📊 Metrics Diff Analysis ReportSummary
ℹ️ About this analysisThis automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:
The last category in particular may indicate planner regressions that should be investigated. New QueriesCount of new queries by file:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.