Skip to content

Show amounts for OP_RETURN outputs - #653

Open
Jacksper13 wants to merge 3 commits into
dev-v2.4.0from
show-op-return-output-amount
Open

Show amounts for OP_RETURN outputs#653
Jacksper13 wants to merge 3 commits into
dev-v2.4.0from
show-op-return-output-amount

Conversation

@Jacksper13

@Jacksper13 Jacksper13 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • show the formatted output amount alongside every OP_RETURN message during transaction review
  • render user-controlled OP_RETURN text literally by escaping LVGL recolor delimiters
  • add simulator regression coverage for zero-value, nonzero-value, forged-markup, and normal address outputs

Root cause

render_output() calculated the output value before classifying the destination, but its OP_RETURN branch returned early without including that value in the trusted-display text. The same branch inserted the decoded OP_RETURN message into a recolor-enabled label without escaping # delimiters, allowing message text to be interpreted as highlighted UI markup.

Impact

Users can review the full economic value of an OP_RETURN output before signing. OP_RETURN messages can no longer create highlighted text that resembles trusted Amount or Destination rows. These changes affect display formatting only; PSBT parsing, fee calculation, and signing behavior are unchanged.

Validation

  • palette-independent renderer regression script exercised with color and monochrome highlight values
  • python -m pycodestyle for the changed Python files
  • git diff --check

@Jacksper13
Jacksper13 marked this pull request as ready for review July 23, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant