Show amounts for OP_RETURN outputs - #653
Open
Jacksper13 wants to merge 3 commits into
Open
Conversation
Jacksper13
marked this pull request as ready for review
July 23, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
render_output()calculated the output value before classifying the destination, but its OP_RETURN branch returned early without including that value in the trusted-display text. The same branch inserted the decoded OP_RETURN message into a recolor-enabled label without escaping#delimiters, allowing message text to be interpreted as highlighted UI markup.Impact
Users can review the full economic value of an OP_RETURN output before signing. OP_RETURN messages can no longer create highlighted text that resembles trusted Amount or Destination rows. These changes affect display formatting only; PSBT parsing, fee calculation, and signing behavior are unchanged.
Validation
python -m pycodestylefor the changed Python filesgit diff --check