Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Basic `dependabot.yml` file

version: 2
updates:
# Enable version updates for GitHub Actions
- package-ecosystem: "github-actions"
# Workflow files stored in the default location of `.github/workflows`
# You don't need to specify `/.github/workflows` for `directory`. You can use `directory: "/"`.
directory: "/"
schedule:
interval: "weekly"
106 changes: 16 additions & 90 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,97 +1,23 @@
# PR Summary
## Description
A short summary of the changes made in this pull-request.

Sci/Tech Reviewer: <!-- SR id, filled by author when ready for review (e.g. @octocat) -->
Code Reviewer: <!-- CR id, filled by SSD -->
Tag the [related issue](https://github.com/FormingWorlds/PROTEUS/issues); e.g. closes #xxx

<!-- To be completed by the developer -->
Include screenshots or log files if appropriate.

<!-- Provide a brief description of the changes in this PR, including any notes
useful for reviewers -->
## Validation of changes
Describe what you did to verify that these changes address the tagged issue.

<!-- List any linked PRs here
- linked MetOffice/<REPO-NAME>#<pr-number>
-->
Outline your test configuration; e.g. MacOS with Python 3.12.

<!-- List any blocking PRs or issues to be closed here
- is blocked-by #pr-number
- blocks #pr-number
- closes #issue-number
- fixes #issue-number
- is related to #issue-number
-->

## Code Quality Checklist
## Checklist

(_Some checks are automatically carried out via the CI pipeline_)

- [ ] I have performed a self-review of my own code
- [ ] My code follows the project's style guidelines
- [ ] Comments have been included that aid undertanding and enhance the
readability of the code
- [ ] My changes generate no new warnings

## Testing

- [ ] If shared files have been modified, I have run the UM and LFRic Apps rose
stem suites
- [ ] If any tests fail (rose-stem or CI) the reason is understood and
acceptable (eg. kgo changes)
- [ ] I have added tests to cover new functionality as appropriate (eg. system
tests, unit tests, etc.)

<!-- Describe other testing performed (if applicable) -->

### trac.log

<!-- Paste your trac.log from testing output here -->

## Security Considerations

- [ ] I have reviewed my changes for potential security issues
- [ ] Sensitive data is properly handled (if applicable)
- [ ] Authentication and authorisation are properly implemented (if applicable)

## Performance Impact

- [ ] Performance of the code has been considered and, if applicable, suitable
performance measurements have been conducted

## AI Assistance and Attribution

- [ ] Some of the content of this change has been produced with the assistance
of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
[Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html)
(including attribution labels)

<!-- If AI has been used, please provide more details here -->

## Documentation

- [ ] Where appropriate I have updated documentation related to this change and
confirmed that it builds correctly

# Sci/Tech Review

<!-- To be completed by the Sci/Tech Reviewer -->
<!-- May be skipped for trivial tickets -->

- [ ] I understand this area of code and the changes being added
- [ ] The proposed changes correspond to the pull request description
- [ ] Documentation is sufficient (do documentation papers need updating)
- [ ] Sufficient testing has been completed

_Please alert the code reviewer via a tag when you have approved the SR_

# Code Review

<!-- To be completed by the Code Reviewer -->

- [ ] All dependencies have been resolved
- [ ] Related Issues have been properly linked and addressed
- [ ] CLA compliance has been confirmed
- [ ] Code quality standards have been met
- [ ] Tests are adequate and have passed
- [ ] Documentation is complete and accurate
- [ ] Security considerations have been addressed
- [ ] Performance impact is acceptable
- [ ] I have followed the [contributing guidelines](https://proteus-framework.org/PROTEUS/CONTRIBUTING.html#how-do-i-contribute)
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] My changes generate no new warnings or errors
- [ ] I have checked that the tests still pass on my computer
- [ ] I have updated the docs, as appropriate
- [ ] I have added tests for these changes, as appropriate
- [ ] I have checked that all dependencies have been updated, as required
7 changes: 5 additions & 2 deletions .github/workflows/build-docs-pdf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@ on:
- 'docs/**'
- '.github/workflows/build-docs-pdf.yaml'
pull_request:
branches:
- main
paths:
- 'docs/**'
- 'version'
- '.github/workflows/build-docs-pdf.yaml'

jobs:
Expand All @@ -19,7 +22,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Install LaTeX dependencies
run: |
Expand All @@ -44,7 +47,7 @@ jobs:
run: bash lx

- name: Upload documentation PDFs
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: docs-pdf
if-no-files-found: error
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
steps:
- uses: actions/configure-pages@v5
- uses: actions/checkout@v5
- uses: actions/setup-python@v5
- uses: actions/configure-pages@v6
- uses: actions/checkout@v7
- uses: actions/setup-python@v7
with:
python-version: 3.x
- name: Find latest successful docs PDF artifact
id: latest-pdf-run
uses: actions/github-script@v7
uses: actions/github-script@v9
with:
script: |
const runsResp = await github.rest.actions.listWorkflowRuns({
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
core.setOutput("run_id", String(selectedRunId));

- name: Download docs PDFs from latest successful build
uses: actions/download-artifact@v5
uses: actions/download-artifact@v8
with:
name: docs-pdf
path: docs
Expand All @@ -87,8 +87,8 @@ jobs:

- run: pip install zensical==0.0.39 markdown-include pymdown-extensions mkdocstrings mkdocstrings-python
- run: zensical build --clean
- uses: actions/upload-pages-artifact@v4
- uses: actions/upload-pages-artifact@v5
with:
path: site
- uses: actions/deploy-pages@v4
- uses: actions/deploy-pages@v5
id: deployment
8 changes: 4 additions & 4 deletions .github/workflows/lint-fortran.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
pull_request:

jobs:
fortitude-lint:
uses: MetOffice/growss/.github/workflows/fortran-lint.yaml@main
with:
runner: "ubuntu-24.04"
fortitude-lint:
permissions:
contents: read # Required to evaluate the event trigger metadata safely
uses: MetOffice/growss/.github/workflows/fortran-lint.yaml@0f9ffe6a138ae9943053621916a850a075997db8 # v1.0.0
16 changes: 16 additions & 0 deletions .github/zizmor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# ------------------------------------------------------------------------------
# (c) Crown copyright Met Office. All rights reserved.
# The file LICENCE, distributed with this code, contains details of the terms
# under which the code may be used.
# ------------------------------------------------------------------------------

# Rules for Zizmor GitHub workflow linter. This file is used to configure which
# rules to ignore for specific workflow files, allowing for exceptions to be
# made where necessary while still enforcing best practices across the codebase.
rules:
dangerous-triggers:
ignore:
- "cla-check.yaml"
- "lint-fortran.yaml"
- "track-review-project.yaml"
- "trigger-project-workflow.yaml"
3 changes: 2 additions & 1 deletion CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
| mo-jmanners | James Manners | Met Office | 2025-12-18 |
| t00sa | Sam Clarke-Green | Met Office | 2026-03-02 |
| Pierre-siddall | Pierre Siddall | Met Office | 2026-03-16 |
| nichollsh | Harrison Nicholls | University of Cambridge | 2026-03-19 |
| stuitje | Karen Stuitje | University of Groningen | 2026-04-11 |
| nichollsh | Harrison Nicholls | University of Cambridge | 2026-03-24 |
| yaswant | Yaswant Pradhan | Met Office | 2026-07-17 |
Loading
Loading