Skip to content

fix(security): require confirm and OS trash for delete_asset (#140) - #172

Merged
Daliys merged 3 commits into
developmentfrom
daliys/issue-140-delete-asset-safety
Jul 28, 2026
Merged

fix(security): require confirm and OS trash for delete_asset (#140)#172
Daliys merged 3 commits into
developmentfrom
daliys/issue-140-delete-asset-safety

Conversation

@Daliys

@Daliys Daliys commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

Implements security controls and path safety for delete_asset as requested in #140:

  • Requires explicit confirm: true parameter for delete_asset calls.
  • Moves deleted assets to OS Trash (AssetDatabase.MoveAssetToTrash) with AssetDatabase.DeleteAsset fallback.
  • Strictly validates asset paths: restricts deletion to subpaths under Assets/, blocking root folder deletion (Assets, Packages, ProjectSettings) and system folders (ProjectSettings/, Packages/).
  • Protects destination paths in move_asset and copy_asset from modifying system folders (ProjectSettings/, Packages/).
  • Prevents direct deletion of .meta files and handles non-existent asset paths gracefully.
  • Adds comprehensive unit tests covering all path edge cases.

Closes #140

@Daliys
Daliys force-pushed the daliys/issue-140-delete-asset-safety branch from 72a800a to cc11a37 Compare July 27, 2026 21:36
@Daliys
Daliys merged commit ca28f5f into development Jul 28, 2026
6 checks passed
@Daliys
Daliys deleted the daliys/issue-140-delete-asset-safety branch July 28, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant