chore(prob-105): deprecate as resolved, with the reason actually in the file - #480
Merged
Merged
Conversation
…he file PROB-105 described a defect that #472 fixed, so it is retired as history rather than deleted. The `## Deprecation` section here was restored by hand through `forgeplan update --body`. `forgeplan deprecate` wrote it to LanceDB only: the status reached the file, the reason did not, and `lance/` is gitignored — so on a fresh clone the reason would simply not exist while `forgeplan get` kept showing it. Filed as #478 with a reproducer on the shipped v0.36.0 binary; `reopen` loses its section the same way, and #479 covers a separate identity defect found in the same run. Refs: prob-105, #472, #478 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Artifact-only. PROB-105 described a defect that #472 fixed (merged as 551ddb9), so it is retired as history rather than deleted.
Why this is a PR and not a one-liner
forgeplan deprecate PROB-105 --reason "..."ran cleanly: it echoed the reason back,forgeplan get PROB-105showed a## Deprecationsection containing it, and the status transitioned. The markdown file got the status and not the reason..forgeplan/lance/is gitignored, so the only durable copy would have been missing the answer to "why was this retired".The section here was restored through
forgeplan update --body, which does project correctly.Filed while recovering:
deprecateandreopenwrite their reason section to LanceDB only. Reproducer on the shipped v0.36.0 binary;renewshares the code shape, unverified.reopenmints the replacement artifact asPROBLEM-001instead of continuing thePROB-sequence.Note for reviewers
CLAUDE.mdRED LINE #8 namescommands/deprecate.rsas the canonical projection flow, and it is — the CLI wrapper re-reads the record and callsrender_projection. The loss happens under it, which is why nothing about the command looks wrong.