Repository navigation
Use Meta.lower instead of ccall(:jl_expand) - #104
Merged
Merged
Conversation
Julia 1.13 moved lowering behind `Core._lower` and the `jl_expand` symbol no longer exists, so `__cacheget_generator__` failed with "could not load symbol jl_expand" on every `fmap` call. `Meta.lower(m, x)` is the public wrapper for the same operation: it calls `ccall(:jl_expand, Any, (Any, Any), x, m)` up to 1.12 and `Core._lower` from 1.13. It is therefore used unconditionally on all supported versions rather than behind a VERSION branch, and is an exact equivalent of the previous ccall on 1.10-1.12. Tests pass on 1.10, 1.11, 1.12, 1.13.0-rc1 and 1.14.0-DEV, including the `@inferred` test in test/cache.jl that covers the generated typeassert. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
simeonschaub
approved these changes
Aug 6, 2026
Member
|
Do you also want to bump the version in the Project.toml, so we can get a new release out right away? |
Member
|
version bumbed in a pr I just merged, so I'll merge also this and tag a release |
Contributor
Author
|
Thanks. Would you mind reporting here when the release is tagged, as this unblocks some work. Much appreciated. |
Member
|
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude:
Julia 1.13 moved lowering behind
Core._lowerand thejl_expandsymbol no longer exists, so__cacheget_generator__failed with "could not load symbol jl_expand" on everyfmapcall.Meta.lower(m, x)is the public wrapper for the same operation: it callsccall(:jl_expand, Any, (Any, Any), x, m)up to 1.12 andCore._lowerfrom 1.13. It is therefore used unconditionally on all supported versions rather than behind a VERSION branch, and is an exact equivalent of the previous ccall on 1.10-1.12.