-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add TDT CoreML export for parakeet-tdt-ctc-110m #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Alex-Wengg
merged 4 commits into
FluidInference:main
from
TigreGotico:feat/tdt-ctc-110m-coreml-export
Mar 16, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
365a516
feat: add TDT CoreML export for parakeet-tdt-ctc-110m
JarbasAl aaebfe9
fix: address PR review — duration slicing bug and iOS deployment target
JarbasAl 73c97bf
fix: resolve dependency conflicts in pyproject.toml
JarbasAl 7475673
fix: target iOS 17 instead of iOS 18 for TDT export
JarbasAl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 README claims iOS 18 deployment target but code uses iOS 17
The README at line 66 states "iOS 18 deployment target: Required for int ops in the encoder's positional encoding" as a key difference from the 0.6B export. However, commit
7475673explicitly changed the deployment target from iOS 18 to iOS 17 in the code (convert-tdt-coreml.py:57andconvert-tdt-coreml.py:185), confirming that iOS 18 is not actually required. The README was not updated to reflect this fix, leaving stale documentation that will mislead users into believing they need iOS 18.Was this helpful? React with 👍 or 👎 to provide feedback.