Skip to content

feat: add initial lumo variables support #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlopezFC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add initial lumo variables support #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions dev/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
<script type="module" src="../fc-applayout.js"></script>
<script type="module" src="../node_modules/@vaadin/vertical-layout/vaadin-vertical-layout.js"></script>
<script type="module" src="../node_modules/@polymer/paper-card/paper-card.js"></script>
<script type="module">
// Import Lumo theme at document level for dark mode support
import '@vaadin/vaadin-lumo-styles/color-global.js';
import '@vaadin/vaadin-lumo-styles/typography-global.js';
</script>
<style>
p {
border: solid 1px blue;
Expand All @@ -16,9 +21,10 @@

html, body {
margin: 0;
font-family: 'Roboto', 'Noto', sans-serif;
font-family: var(--lumo-font-family);
-webkit-font-smoothing: antialiased;
background: #f1f1f1;
background: var(--lumo-base-color);
color: var(--lumo-body-text-color);
max-height: 368px;
max-width: 100%;
}
Expand All @@ -33,9 +39,6 @@

app-drawer {
--app-drawer-scrim-background: rgba(0, 0, 100, 0.8);
--app-drawer-content-container: {
background-color: #F1F1F1;
}
z-index: 1001;
}

Expand All @@ -56,6 +59,7 @@

.hamlet {
user-select: none;
color: black;
}

.hamlet paper-card {
Expand All @@ -67,7 +71,10 @@
background: rgb(220,248,198);
}

.hamlet paper-card h5 {margin-top: 0.25em}
.hamlet paper-card h5 {
margin-top: 0.25em;
color: black;
}

.hamlet paper-card[elevation="0"] {
background: rgb(254,244,197);
Expand Down Expand Up @@ -97,6 +104,7 @@
<img slot="title" class="applogo" src="./applogo.png" alt="applogo">
<div slot="title" main-title="">AppLayout Vaadin 14 Demo</div>
<paper-icon-button disabled slot="toolbar" icon="block" role="button" tabindex="0" aria-disabled="false"></paper-icon-button>
<paper-icon-button id="darkModeToggle" slot="toolbar" icon="invert-colors" title="Toggle Dark Mode" role="button" tabindex="0" aria-disabled="false"></paper-icon-button>

Check warning on line 107 in dev/index.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add a 'onKeyPress|onKeyDown|onKeyUp' attribute to this <paper-icon-button> tag. 


See more on https://sonarcloud.io/project/issues?id=FlowingCode_fc-applayout&issues=AZ3VbQgZoRkwqxFDC647&open=AZ3VbQgZoRkwqxFDC647&pullRequest=29
<paper-icon-button slot="toolbar" icon="settings" title="Settings" role="button" tabindex="0" aria-disabled="false"></paper-icon-button>
<div slot="menu">
<p onclick="this.dispatchEvent(new CustomEvent('item-clicked', {bubbles: true}))">This is menu</p>
Expand Down Expand Up @@ -150,5 +158,22 @@
Howe'er my haps, my joys were ne'er begun. </span></div></div></paper-card><paper-card elevation="0" aria-label=""><div class="card-content"><span>Claudius exits</span></div></paper-card></vaadin-vertical-layout>
</div>
</fc-applayout>
<script>
// Dark mode toggle functionality
document.addEventListener('DOMContentLoaded', () => {
const darkModeToggle = document.getElementById('darkModeToggle');

if (darkModeToggle) {
darkModeToggle.addEventListener('click', () => {
const currentTheme = document.documentElement.getAttribute('theme');
if (currentTheme === 'dark') {
document.documentElement.removeAttribute('theme');
} else {
document.documentElement.setAttribute('theme', 'dark');
}
});
}
});
</script>
</body>
</html>
98 changes: 52 additions & 46 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
"@polymer/paper-card": "^3.0.1",
"@polymer/paper-icon-button": "^3.0.2",
"@polymer/paper-listbox": "^3.0.1",
"@vaadin/vaadin-themable-mixin": "24.3.8",
"@vaadin/vaadin-lumo-styles": "24.3.11",
"@vaadin/vaadin-themable-mixin": "24.3.11",
"lit": "^3.1.2"
},
"devDependencies": {
Expand Down Expand Up @@ -86,4 +87,4 @@
"typescript": "5.3.3"
},
"customElements": "custom-elements.json"
}
}
Loading