Skip to content

Fix integration tests#26

Merged
javier-godoy merged 3 commits intomasterfrom
fix-integration-tests
Feb 26, 2026
Merged

Fix integration tests#26
javier-godoy merged 3 commits intomasterfrom
fix-integration-tests

Conversation

@paodb
Copy link
Member

@paodb paodb commented Feb 25, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated core dependency to a newer version for improved compatibility and stability.
    • Updated testing infrastructure configuration to align with modern development standards.

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8844a76 and 5dc3da2.

📒 Files selected for processing (3)
  • pom.xml
  • src/test/java/com/flowingcode/vaadin/addons/extendedlogin/it/ExtendedLoginOverlayIT.java
  • src/test/java/com/flowingcode/vaadin/addons/extendedlogin/it/LoginLayoutIT.java

Walkthrough

Dependency version bump for webdrivermanager from 5.1.1 to 5.9.2, Jetty plugin configuration parameter changes from scanIntervalSeconds to scan, and test class constructor invocations updated to reference extended resource paths.

Changes

Cohort / File(s) Summary
Build Configuration
pom.xml
Upgraded io.github.bonigarcia:webdrivermanager dependency to 5.9.2; updated Jetty plugin configuration in both main and integration-tests profiles, replacing scanIntervalSeconds parameters with scan.
Test Infrastructure
src/test/java/com/flowingcode/vaadin/addons/extendedlogin/it/ExtendedLoginOverlayIT.java, src/test/java/com/flowingcode/vaadin/addons/extendedlogin/it/LoginLayoutIT.java
Updated superclass constructor calls to use extended resource paths: "extended-login/login-overlay" and "extended-login/login-layout" respectively.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix integration tests' accurately describes the main change in the PR, which involves modifying test initialization paths in two integration test files to make them work correctly.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-integration-tests

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@paodb paodb marked this pull request as ready for review February 25, 2026 19:51
@javier-godoy javier-godoy merged commit 7586f5c into master Feb 26, 2026
5 checks passed
@javier-godoy javier-godoy deleted the fix-integration-tests branch February 26, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants