fix: added fixes for phantom docs, storage name resolution and subcollections#8
Open
lookieAU wants to merge 2 commits into
Open
fix: added fixes for phantom docs, storage name resolution and subcollections#8lookieAU wants to merge 2 commits into
lookieAU wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature add-ons:
Added nested documents/sub-collection feature -> expanding a document with a sub-collection now allows the user to expand as many nested sub-collections that are present
Recursive delete -> Deleting a document now removes its sub-collections as well (added in confirmation pop-up as well)
Bugs:
Fixed the phantom document bug -> Documents with no data but having sub-collections got dropped from the tree/list/json as get() was being used. However, admin SDK supports list documents which allow us to list phantom docs and their sub-collections (also works the same way on Firefoo)
Fixed storage bug -> App hardcoded appspot.com to admin sdk based firebase storage URLs. Post-2024 these have changed to firebasestorage.app so it has been updated accordingly as well as fallback to the original suffix
Tests
Note