-
Notifications
You must be signed in to change notification settings - Fork 7
docs(qual): resolve late PLAN3 review findings #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
03177e2
docs(qual): resolve late PLAN3 review findings
Abiorh001 f9f2be5
docs(qual): align mutation policy authorities
Abiorh001 f6dd56b
docs(qual): record PLAN3R1 review evidence
Abiorh001 0fde0ff
docs(qual): address PR review consistency
Abiorh001 c87f927
Merge branch 'main' into codex/ws-qual-001-plan3r1-late-review
abiorh-claw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
...nd-coverage-floor/chunks/WS-QUAL-001-PLAN3R1-late-external-review-correction.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| # Chunk Contract: WS-QUAL-001-PLAN3R1 — Late External Review Correction | ||
|
|
||
| ## Parent initiative | ||
|
|
||
| `WS-QUAL-001` — Behavior And Mutation Assurance | ||
|
|
||
| ## Goal | ||
|
|
||
| Correct the five valid CodeRabbit findings that arrived before PR #272 merged | ||
| but were not addressed before the branch was deleted. | ||
|
|
||
| ## Why this chunk exists | ||
|
|
||
| PR #272 changed planning only, so no unsafe mutation runtime was deployed. | ||
| However, its merged plan leaves ambiguity in dependency custody, mutation | ||
| outcome handling, fixture-only classifications, target selection, and exact | ||
| Backend evidence binding. Those ambiguities must be removed before `04M` may | ||
| start. | ||
|
|
||
| ## Risk class | ||
|
|
||
| L1 — CI/test policy planning correction. | ||
|
|
||
| ## Machine scope | ||
|
|
||
| ```chunk-scope-json | ||
| { | ||
| "schema_version": 1, | ||
| "chunk_id": "WS-QUAL-001-PLAN3R1", | ||
| "allowed_paths": [ | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/CHUNK_MAP.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/PLAN.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/STATUS.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/chunks/README.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/chunks/WS-QUAL-001-04M-changed-scope-mutation-pilot.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/chunks/WS-QUAL-001-05M-blocking-behavior-mutation-gate.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/chunks/WS-QUAL-001-PLAN3R1-late-external-review-correction.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/reviews/WS-QUAL-001-PLAN3-pr-trust-bundle.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/reviews/WS-QUAL-001-PLAN3R1-external-review-response.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/reviews/WS-QUAL-001-PLAN3R1-internal-review-evidence.md", | ||
| ".agent-loop/initiatives/WS-QUAL-001-backend-coverage-floor/reviews/WS-QUAL-001-PLAN3R1-pr-trust-bundle.md", | ||
| ".agent-loop/merge-intents/WS-QUAL-001-PLAN3R1.json" | ||
| ], | ||
| "forbidden_paths": [ | ||
| ".github/**", | ||
| "backend/**", | ||
| "scripts/**" | ||
| ], | ||
| "verification_commands": [ | ||
| "markdown-links", | ||
| "stale-wording", | ||
| "lightweight-agent-gates", | ||
| "git-diff-check" | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| ## Not allowed | ||
|
|
||
| ```text | ||
| workflow, dependency, backend, test, or mutation implementation | ||
| coverage-threshold changes | ||
| automatic start of 04M or 05M | ||
| changes outside the WS-QUAL-001 correction evidence and merge intent | ||
| ``` | ||
|
|
||
| ## Acceptance criteria | ||
|
|
||
| - [ ] PR code cannot choose or modify the mutation-tool dependency authority. | ||
| - [ ] Eligible changed production targets are always selected; bounded | ||
| test-only behavior claims are additive and name owning test nodes. | ||
| - [ ] Every engine outcome fails closed or has an independently verified typed | ||
| policy classification. | ||
| - [ ] Fixture-only changes require proof before receiving a non-behavioral | ||
| classification. | ||
| - [ ] PLAN3 Backend evidence names both exact run and commit. | ||
| - [ ] All five late comments are recorded and resolved before `04M` starts. | ||
|
|
||
| ## Required reviewers | ||
|
|
||
| - senior engineering | ||
| - QA/test | ||
| - security/auth | ||
| - product/ops | ||
| - architecture | ||
| - CI integrity | ||
| - docs | ||
| - reuse/dedup | ||
| - test delta | ||
|
|
||
| ## Human review focus | ||
|
|
||
| Confirm this correction closes the five late comments without implementing or | ||
| pre-authorizing mutation CI. | ||
|
|
||
| ## Stop conditions | ||
|
|
||
| Stop if the correction requires executable workflow, dependency, backend, test, | ||
| or mutation changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
...-backend-coverage-floor/reviews/WS-QUAL-001-PLAN3R1-external-review-response.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # WS-QUAL-001-PLAN3R1 External Review Response | ||
|
|
||
| ## Comments addressed | ||
|
|
||
| - PR #272 discussion `3714978005`: PR-editable dependency manifests are no | ||
| longer trusted as mutation-tool authority; the contract requires authority | ||
| from a protected base revision or an equivalent protected runtime that | ||
| already exists before 04M and cannot be introduced or modified by 04M. | ||
| - PR #272 discussion `3714978015`: test-only behavior claims are additive and | ||
| cannot replace mutation of eligible changed production targets. | ||
| - PR #272 discussion `3714978020`: every engine status must block or map to an | ||
| independently verified typed classification; implicit passing is forbidden. | ||
| - PR #272 discussion `3714978023`: fixture-only changes are exempt only after | ||
| evidence proves they cannot influence selection, inputs, or assertions. | ||
| - PR #272 discussion `3714978026`: PLAN3 Backend evidence now binds run | ||
| `30926337804` to commit `5f2baf90`. | ||
|
|
||
| ## PR #278 follow-up comments addressed | ||
|
|
||
| - Standardized the canonical mutation status label as `error` across PLAN, | ||
| 04M evidence, INTENT, DISCOVERY, and the 05M gateway. | ||
| - Separated the PLAN3R1 stop, explicit 04M start, 04M calibration checkpoint, | ||
| and explicit evidence-bound 05M start. | ||
| - Clarified that dependency authority comes from a protected base revision. | ||
| - Corrected the trust-bundle scope evidence to twelve changed paths. | ||
|
|
||
| ## Comments deferred | ||
|
|
||
| None. | ||
|
|
||
| ## Human decisions needed | ||
|
|
||
| None. This chunk corrects merged planning and does not implement mutation CI. | ||
|
|
||
| ## Commands rerun | ||
|
|
||
| - `python3 scripts/check_markdown_links.py` | ||
| - `python3 scripts/check_stale_workstream_wording.py` | ||
| - `python3 scripts/check_stale_authorization_docs.py` | ||
| - `python3 scripts/check_stale_artifact_contracts.py` | ||
| - `PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python3 -m pytest -q scripts/test_lightweight_agent_gates.py` | ||
| - `git diff --check` | ||
|
|
||
| ## Remaining risks | ||
|
|
||
| The mutation engine and exact executable policy remain intentionally undecided | ||
| until separately authorized `WS-QUAL-001-04M` implementation and hosted pilot | ||
| evidence. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.