-
Notifications
You must be signed in to change notification settings - Fork 7
WS-XINT-003-02C: add REV authorization readiness #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b44855b
feat(auth): add REV catalogue readiness
Abiorh001 16d26d8
test(auth): update 0049 schema fingerprint
Abiorh001 0fdc750
docs(auth): reconcile 02C review status
Abiorh001 45217a0
test(auth): repair 0049 migration fixtures
Abiorh001 ed89467
test(auth): align identity constraint probe
Abiorh001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
...INT-003-rev-auth-end-to-end/reviews/WS-XINT-003-02C-external-review-response.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # External Review Response: WS-XINT-003-02C | ||
|
|
||
| ## Hosted CI | ||
|
|
||
| The first Backend run exposed the expected public-schema fingerprint change | ||
| from migration 0049. The exact observed fingerprint replaced the pre-0049 | ||
| value; no reset allow-list or integrity behavior changed. | ||
|
|
||
| The next schema-B lane exposed two fixture-only omissions: historical | ||
| action-parity tests needed to exclude the new 0049 owners while exercising the | ||
| 0021/0022 snapshots, and each new service-profile downgrade fixture needed its | ||
| mandatory identity link. Both fixture lifecycles now match their migration | ||
| era; runtime constraints were not relaxed. | ||
|
|
||
| Schema-A then confirmed PostgreSQL renders `actor_kind` literals with a | ||
| different cast from the service-identity allow-list. The exact-value assertion | ||
| continues parsing every `character varying` allow-list literal (including any | ||
| unexpected namespace), while correctly excluding the separately cast | ||
| `human`/`service` kind predicates. | ||
|
|
||
| ## CodeRabbit | ||
|
|
||
| Two documentation findings were valid and fixed: | ||
|
|
||
| - the original nineteen REV actions still retain their historical runtime | ||
| `ActionOwner` values until their exact activation waves replace them; | ||
| - the 02C contract status now records completed implementation/internal review | ||
| and pending hosted exact-head evidence. | ||
|
|
||
| No runtime or authorization behavior was relaxed in either correction. |
34 changes: 34 additions & 0 deletions
34
...ives/WS-XINT-003-rev-auth-end-to-end/reviews/WS-XINT-003-02C-internal-review.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Internal Review: WS-XINT-003-02C | ||
|
|
||
| ## Scope | ||
|
|
||
| Final review of the availability-neutral REV authorization catalogue, | ||
| fixed-service registry/matrix, and PostgreSQL parity migration. | ||
|
|
||
| ## Results | ||
|
|
||
| - Architecture: PASS WITH LOW RISKS; 02C stays separate from PREP and REV behavior. | ||
| - Security/auth: PASS WITH LOW RISKS; no grant, route, job, or active authority is added. | ||
| - Product/operations: PASS WITH LOW RISKS; Project Manager, Operator, and service custody remain distinct. | ||
| - QA: PASS WITH LOW RISKS after no-grant provisioning proof was added. | ||
| - Senior engineering: PASS WITH LOW RISKS after current catalogue wording was corrected. | ||
| - CI integrity: PASS WITH LOW RISKS after focused selectors explicitly loaded async support and selected 02C tests. | ||
| - Test delta: PASS WITH LOW RISKS after exact database constraint closure replaced presence-only assertions. | ||
| - Reuse/dedup: PASS; existing catalogue, matrix, migration, and fixture patterns remain the sole abstractions. | ||
| - Docs: PASS WITH LOW RISKS after the complete fourteen-identity matrix and 0049 operator guidance were added. | ||
|
|
||
| No blocking finding remains. All reviewer sessions completed. | ||
|
|
||
| ## Deterministic evidence | ||
|
|
||
| - Ruff and mypy pass on the changed backend surface. | ||
| - 33 focused catalogue, service-matrix, custody, and documentation tests pass. | ||
| - Changed-module coverage is 100.00 percent for `service_identities.py` and | ||
| 97.89 percent for `catalogue.py`. | ||
| - All 16 exact database/API tests collect successfully. | ||
| - Stale authorization/review scans, Markdown links, and whitespace checks pass. | ||
|
|
||
| The worktree has no `WORKSTREAM_TEST_DATABASE_URL`; PostgreSQL execution, the | ||
| six-principal API case, schema lanes, and repository-wide 78-percent coverage | ||
| remain assigned to hosted GitHub Actions on the exact PR head. | ||
|
|
46 changes: 46 additions & 0 deletions
46
...ives/WS-XINT-003-rev-auth-end-to-end/reviews/WS-XINT-003-02C-pr-trust-bundle.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # PR Trust Bundle: WS-XINT-003-02C | ||
|
|
||
| ## Intent and scope | ||
|
|
||
| Register the complete unavailable REV authorization vocabulary and exact fixed | ||
| service principals before REV implementation begins. This chunk adds four | ||
| planned actions, six closed identities, six static matrix rows, and database | ||
| parity only. | ||
|
|
||
| ## Design and safety | ||
|
|
||
| - Catalogue totals become 71 permissions, 100 actions, 45 active, and 55 planned. | ||
| - The fixed-service registry becomes fourteen rows with twenty-two memberships. | ||
| - Two separate reconciliation identities share only `review.reconcile.run`; | ||
| future REV code must derive their modes server-side. | ||
| - Evidence-ingest actions remain planned, outside the service matrix, and | ||
| protected by `FUTURE_INTENT_REQUIRED_ACTIONS`. | ||
| - Migration 0049 seeds no principal or authority and refuses unsafe downgrade | ||
| after direct/linked action evidence or use of any new identity. | ||
|
|
||
| ## Exclusions | ||
|
|
||
| No REV queue, lease, finding, decision, revision, recovery, projection, | ||
| lifecycle behavior, PREP protocol, route, worker, provider I/O, or action | ||
| activation is included. | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Ruff: pass. | ||
| - Mypy: pass. | ||
| - Focused tests: 33 passed. | ||
| - Changed-module coverage: 100.00 and 97.89 percent. | ||
| - Exact DB/API collection: 16 tests collected. | ||
| - Internal architecture, security, product, QA, senior, CI, test-delta, reuse, | ||
| and docs review: pass; valid findings resolved. | ||
| - Markdown links, stale review contracts, and diff whitespace: pass. | ||
|
|
||
| Hosted GitHub Actions must provide PostgreSQL schema/API execution, full-suite | ||
| coverage (repository 78 percent and changed authorization/actor subsystems 90 | ||
| percent), and the final exact-head merge evidence. | ||
|
|
||
| ## Human review focus | ||
|
|
||
| Verify the four action/permission/owner triples, the six identity-to-action | ||
| rows, the exact 0048-to-0049 constraint transformation, and that no availability | ||
| or product behavior changed. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.