Skip to content

Fix incorrect pinyin highlight for polyphonic characters (e.g. 核查 with hecha/heia) #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −3
Draft

Fix incorrect pinyin highlight for polyphonic characters (e.g. 核查 with hecha/heia) #4607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2ddd6a
Initial plan
Copilot Aug 6, 2026
7dea470
Fix incorrect pinyin highlight: use GetAllPinyin per character instea…
Copilot Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Flow.Launcher.Infrastructure/PinyinAlphabet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,20 @@ public bool ShouldTranslate(string stringToTranslate)

private (string translation, TranslationMapping map) BuildCacheFromContent(string content)
{
var resultList = WordsHelper.GetPinyinList(content);
var resultBuilder = new StringBuilder(_settings.UseDoublePinyin ? 3 : 4); // Pre-allocate with estimated capacity
var map = new TranslationMapping();

var previousIsChinese = false;

for (var i = 0; i < resultList.Length; i++)
for (var i = 0; i < content.Length; i++)
{
if (IsChineseCharacter(content[i]))
{
var translated = _settings.UseDoublePinyin ? ToDoublePinyin(resultList[i]) : resultList[i];
// Use GetAllPinyin per character to avoid incorrect context-sensitive pinyin disambiguation.
// For example, GetPinyinList("核查") returns ["He","Zha"] but '查' should be "Cha" here.
var allPinyins = WordsHelper.GetAllPinyin(content[i], false);
var pinyin = allPinyins.Count > 0 ? allPinyins[0] : WordsHelper.GetPinyinList(content[i].ToString(), false)[0];
var translated = _settings.UseDoublePinyin ? ToDoublePinyin(pinyin) : pinyin;

if (i > 0 && content[i - 1] != ' ')
{
Expand Down
Loading