Skip to content

Fix show history result start up - #4605

Merged
jjw24 merged 1 commit into
devfrom
fix_startup_history_result
Aug 5, 2026
Merged

Fix show history result start up#4605
jjw24 merged 1 commit into
devfrom
fix_startup_history_result

Conversation

@jjw24

@jjw24 jjw24 commented Aug 5, 2026

Copy link
Copy Markdown
Member

When history results option is turned on but home page results is not, starting up flow will not show history results.

Follows on from #4042


Summary by cubic

Fixes startup so history results show when that option is enabled, even if the home page is disabled. Users now see their recent history on launch as expected.

Summary of changes

  • Changed: In OnLoaded, trigger initial QueryResults when ShowHomePage OR ShowHistoryResultsForHomePage is true and the query is empty.
  • Added: Support showing history results on startup when only history-for-home-page is enabled.
  • Removed: Nothing; no logic paths or settings were removed.
  • Memory impact: None; a single conditional check changed.
  • Security risks: None; UI initialization only.
  • Tests: No new unit tests added.

Release Note
History results now appear on startup when the “show history on home page” option is enabled, even if the home page is turned off.

Written for commit 59e6371. Summary will update on new commits.

Review in cubic

@jjw24 jjw24 added this to the 2.2.0 milestone Aug 5, 2026
@jjw24 jjw24 self-assigned this Aug 5, 2026
@jjw24 jjw24 added the Dev branch only An issue or fix for the Dev branch build label Aug 5, 2026
@jjw24
jjw24 enabled auto-merge August 5, 2026 12:02

@Jack251970 Jack251970 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The homepage query-results condition now also checks ShowHistoryResultsForHomePage. Empty homepage queries can therefore load history results when that setting is enabled.

Changes

Homepage history results

Layer / File(s) Summary
Expand empty-query loading condition
Flow.Launcher/MainWindow.xaml.cs
The initial query-results flow runs when homepage results or homepage history results are enabled and the query is empty.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: jack251970, davidgbrett

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title directly addresses the main change: enabling history results display at startup when the history option is enabled.
Description check ✅ Passed The description explains the bug fix, states the condition when the issue occurs, and references the related PR.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_startup_history_result

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jjw24
jjw24 merged commit 3c2e995 into dev Aug 5, 2026
6 checks passed
@jjw24
jjw24 deleted the fix_startup_history_result branch August 5, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev branch only An issue or fix for the Dev branch build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants