Skip to content

Add option to plugin indicator context menu to open settings window of indicated plugin - #4604

Merged
DavidGBrett merged 1 commit into
devfrom
plugin-indicator-plugin-settings
Aug 5, 2026
Merged

Add option to plugin indicator context menu to open settings window of indicated plugin#4604
DavidGBrett merged 1 commit into
devfrom
plugin-indicator-plugin-settings

Conversation

@DavidGBrett

@DavidGBrett DavidGBrett commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Calls the OpenPluginSettingsWindow api method with the id of the indicated plugin.

Screenshot

image

Summary by cubic

Adds a context menu action in Plugin Indicator results to open the indicated plugin’s settings window for faster access to configuration.

  • Summary of changes

    • Changed: Implemented IContextMenu in Main and set Result.ContextData = plugin for produced results.
    • Added: LoadContextMenus returns a “Settings: {plugin}” action that calls Context.API.OpenPluginSettingsWindow(plugin.ID); added English title/subtitle strings.
    • Removed: No existing logic removed.
    • Memory: Negligible impact; stores a PluginMetadata reference per result only during query lifecycle.
    • Security: Low risk; uses trusted plugin metadata and existing API; no external input or elevated permissions.
    • Tests: No new unit tests added.
  • Release Note
    Open a plugin’s settings directly from its result in the Plugin Indicator via the context menu.

Written for commit 99daf57. Summary will update on new commits.

Review in cubic

…f indicated plugin

Calls the OpenPluginSettingsWindow api method with the id of the indicated plugin
@github-actions github-actions Bot added this to the 2.2.0 milestone Aug 5, 2026
@DavidGBrett DavidGBrett added the enhancement New feature or request label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Plugin Indicator now exposes plugin settings through a context-menu action. Query results retain plugin metadata, and English localization strings define the settings title and action text.

Changes

Plugin Indicator settings access

Layer / File(s) Summary
Plugin settings context menu
Plugins/Flow.Launcher.Plugin.PluginIndicator/Main.cs, Plugins/Flow.Launcher.Plugin.PluginIndicator/Languages/en.xaml
Main implements IContextMenu, stores PluginMetadata in query results, and creates a settings menu item for selected plugins. English localization strings define the settings title and action text.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes adding a context-menu option to open the indicated plugin's settings window.
Description check ✅ Passed The description explains that the context menu opens the indicated plugin's settings window through the existing API.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch plugin-indicator-plugin-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@DavidGBrett
DavidGBrett enabled auto-merge (squash) August 5, 2026 07:45
@DavidGBrett
DavidGBrett requested review from Jack251970 and jjw24 August 5, 2026 07:46

@Jack251970 Jack251970 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DavidGBrett
DavidGBrett merged commit 5e391b4 into dev Aug 5, 2026
6 checks passed
@DavidGBrett
DavidGBrett deleted the plugin-indicator-plugin-settings branch August 5, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants