Fix home page result context menus - #4600
Merged
Merged
Conversation
…sults These show up when there is no query but we were ignoring the arrow key if there was no query Removed that filter to fix this
The ignored query text flag is meant to skip a redundant search when the query text is restored programmatically, such as returning from the context menu. But it also stopped the context menu and history from rebuilding, so on the home page they kept showing stale results. We now apply the flag only when running a search, so the context menu and history are always rebuilt fresh.
Contributor
📝 WalkthroughWalkthroughThe Right Arrow handler now opens the result context menu for selected results with an empty query. ChangesQuery context-menu flow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Jack251970
approved these changes
Aug 3, 2026
Jack251970
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs related to home page results and context menus.
Fix 1 Arrow Input Broken
Fixes #4599 where the right arrow input to open the context menu wasn't working.
Fix 2 Stale Context Menus
Also fixes another bug where the context menu itself was stale and not rebuilt when a new result had its context menu opened.
This was becasue of the ignored query text flag incorrectly applying because each context menu used the same empty string query.
Fixed that by making that check only apply to search queries.
(the problem for fix 2 wasn't obvious before because the plugin indicator plugin for example had nothing to show in its context menu anyways)
Summary by cubic
Fixes two home page context menu bugs: the Right arrow now opens menus on results without a search query, and menus rebuild so they no longer show stale options.
Summary of changes
_ignoredQueryTextnow applies only when search results are selected, preventing stale context menus/history._ignoredQueryTextoutside search views.Release Note
Written for commit 3c5eaaf. Summary will update on new commits.