Always copy share-page links and remove profile copy formats - #214
Merged
Merged
Conversation
|
Flare PR preview: closed Preview and disposable data removed. Commit:
|
FlintSH
marked this pull request as ready for review
September 16, 2026 14:59
Greptile Summary
Confidence Score: 5/5Safe to merge; the changed upload-link compatibility and preference-navigation behavior completed successfully. No issues were found. Focused upload endpoint checks confirmed legacy copy-format inputs produce the intended normalized links, and rendered navigation checks confirmed legacy bookmarks select and reveal the intended current settings. Files Needing Attention: None.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upload profiles could make Copy link return Markdown, HTML, raw-file URLs, or download URLs. Copy actions now consistently return the plain share-page URL across web uploads, pastes, bulk actions, notifications, and generated screenshot tools.
Remove the profile's Copy format selector and preset setting. The upload API always returns the share-page URL in
url,pageUrl, and the legacycopyTextalias, so previously downloaded uploader configurations keep working. Ignore retiredcopyFormatvalues in saved profiles, imported recipes, requests, and in-progress chunk snapshots; all other profile preferences and validation remain in place.Expected UI changes: the profile editor no longer has a Copy format selector, and the Public screenshots starter describes its minimal share page and random filenames. Paste share-link fields show plain share-page URLs.
Fixes #213.
Validation: