Skip to content

Always copy share-page links and remove profile copy formats - #214

Merged
FlintSH merged 2 commits into
mainfrom
fix/upload-copy-links
Sep 16, 2026
Merged

FlintSH merged 2 commits into
mainfrom
fix/upload-copy-links

Conversation

@FlintSH

@FlintSH FlintSH commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Upload profiles could make Copy link return Markdown, HTML, raw-file URLs, or download URLs. Copy actions now consistently return the plain share-page URL across web uploads, pastes, bulk actions, notifications, and generated screenshot tools.

Remove the profile's Copy format selector and preset setting. The upload API always returns the share-page URL in url, pageUrl, and the legacy copyText alias, so previously downloaded uploader configurations keep working. Ignore retired copyFormat values in saved profiles, imported recipes, requests, and in-progress chunk snapshots; all other profile preferences and validation remain in place.

Expected UI changes: the profile editor no longer has a Copy format selector, and the Public screenshots starter describes its minimal share page and random filenames. Paste share-link fields show plain share-page URLs.

Fixes #213.

Validation:

  • 375 unit tests passed.
  • 20 database integration tests passed against a fresh disposable PostgreSQL database, including legacy Markdown/HTML/raw/download profiles through multipart and both chunk-completion APIs, plus profile listing/export/import.
  • 42 browser checks passed with real clipboard readback and mocked upload responses, covering individual/bulk actions, notifications, paste fields, old response formats, and the removed profile control. Desktop/mobile screenshots reviewed; no browser errors.
  • TypeScript, ESLint on changed files, Prettier, and diff checks passed.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Flare PR preview: closed

Preview and disposable data removed.

Commit: 1ffaa0168932

Public, disposable test instance running untrusted PR code. Anyone can view or change its test data. Do not enter passwords you use elsewhere, credentials, or private files.

@FlintSH FlintSH changed the title Fix Copy link returning Markdown after uploads Always copy share-page links and remove profile copy formats Sep 16, 2026
@FlintSH
FlintSH marked this pull request as ready for review September 16, 2026 14:59
@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

Greptile Summary

  • Standardized upload responses so current and legacy clients receive the encoded share-page URL in url, pageUrl, and copyText.
  • Retired copy-format persistence while continuing to accept legacy profile, recipe, request, and in-progress chunk values.
  • Updated generated uploader configurations and dashboard copy actions to use plain share-page URLs.
  • Added Settings and Profile bookmark aliases that preserve query parameters and open the intended current preference card.

Confidence Score: 5/5

Safe to merge; the changed upload-link compatibility and preference-navigation behavior completed successfully.

No issues were found. Focused upload endpoint checks confirmed legacy copy-format inputs produce the intended normalized links, and rendered navigation checks confirmed legacy bookmarks select and reveal the intended current settings.

Files Needing Attention: None.

T-Rex T-Rex Logs

What T-Rex did

  • Authored and ran the upload API compatibility test script, and compared its before/after outputs against base revision and PR HEAD.
  • Verified that the PR head check returns HTTP 200 for legacy copyFormat and clarified that the share-page URL components url, pageUrl, and copyText align, while rawUrl and downloadUrl stay distinct.
  • Authored and executed the render navigation proof workflow, including the Chromium navigation script and the navigation proof command script.
  • Observed the render navigation proof results, including the output showing 21 passing tests.
  • Captured before/after render recordings to document navigation behavior changes for legacy bookmarks.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Remove profile copy formats and always s..." | Re-trigger Greptile

@FlintSH
FlintSH merged commit 771ec14 into main Sep 16, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] copy link button copies it in markdown format, not just the link

1 participant