Skip to content

Group related Profile and Settings options - #210

Merged
FlintSH merged 1 commit into
mainfrom
ui/group-profile-settings
Sep 16, 2026
Merged

FlintSH merged 1 commit into
mainfrom
ui/group-profile-settings

Conversation

@FlintSH

@FlintSH FlintSH commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Profile and Settings had several separate sections with only one or two cards. This groups related controls while keeping the current visual design.

Page New grouping
Profile: 6 → 4 sections Account now includes identity, password, and personal theme. Uploads, Integrations, and Your data remain separate.
Settings: 7 → 5 sections General includes version information. Appearance includes a collapsible Custom CSS and HTML group. Access, Storage, and Email remain separate.

Old Appearance/Security/About/Advanced bookmarks resolve to the relevant cards, including recovery links. Section navigation and browser history retain unfinished edits. Save/Discard stays above the footer on the longer Appearance page, and CSS edits appear under Appearance in the save summary.

Validation:

  • CI passed the production build, TypeScript, lint, formatting, and security analysis.
  • CI test suite: 399 passed, 1 skipped, including database-backed tests. New cases cover legacy URLs, authorization, history, anchor navigation, and disclosure opening.
  • Real-browser checks at desktop and 390px mobile cover every section, old bookmarks/recovery, unfinished edits, save/discard, persisted profile/theme/CSS settings, and URL preservation after refresh.
  • Cloud visual comparison: 29 of 145 screens changed. Reviewed all 12 representative before/after images and DOM diffs; changes match the consolidation, moved controls, and save-bar fix. No unintended app regressions observed. Meticulous still requires human approval of these visual changes.
  • Replay limitation: some older recordings click removed/repositioned tabs, so later actions in those recordings no longer cover the original flow. One recording selects Your data at the old Security position. Refresh these recordings for the new navigation; direct browser checks separately verified all sections and legacy links.
  • Both AMD64 and ARM64 Docker builds passed.
Desktop and mobile screenshots
Profile / Account Settings / General
Profile Account desktop Settings General desktop
Profile Account mobile Settings General mobile

Custom CSS and HTML within Appearance

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Flare PR preview: closed

Preview and disposable data removed.

Commit: c3d540bb4c3e

Public, disposable test instance running untrusted PR code. Anyone can view or change its test data. Do not enter passwords you use elsewhere, credentials, or private files.

@alwaysmeticulous

alwaysmeticulous Bot commented Sep 16, 2026

Copy link
Copy Markdown

✅ Meticulous spotted visual differences in 29 of 145 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~4 hours of user flows which tested 297/403 of the executable lines edited in your PR1.

1. These 106 untested lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost.

Last updated for commit c3d540b Group related Profile and Settings options. This comment will update as new commits are pushed.

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

Greptile Summary

This change consolidates Profile and Settings controls into clearer grouped sections while keeping legacy section URLs functional. The recovery experience continues to let administrators leave the recovery view and return to the live Appearance page. No actionable issues were found; the change is safe to merge.

Confidence Score: 5/5

Safe to merge: no blocking or non-blocking issues were found.

No actionable findings remain after exercising the recovery navigation and access boundary.

Files Needing Attention: None.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the general-contract validation to assess the recovery flow on settings pages, confirming the recovery-active source URL and recovery-inactive target.
  • Verified that the recovery state requires the exact recovery=1 parameter on approved routes, followed by a current administrator session check.
  • Reviewed the documented recovery flow and confirmed administrators are instructed to return to the non-recovery Appearance URL to inspect live results.
  • Cross-checked with a separate validation pass and confirmed there is no security issue; recovery remains authenticated and administrator-only to approved routes.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Group related Profile and Settings optio..." | Re-trigger Greptile

@FlintSH
FlintSH merged commit b6fd7ef into main Sep 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant